Some minor performance improvements to buffer 4b mat mul. #15989
+26
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15989
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 664b48c with merge base 2ebed88 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87910988. |
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 26, 2025
trivedivivek
added
the
release notes: vulkan
yipjustin
approved these changes
Nov 26, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 26, 2025
trivedivivek
force-pushed
the
export-D87910988
branch
from
1d4b9f4 to
4b71f48
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 26, 2025
trivedivivek
force-pushed
the
export-D87910988
branch
from
4b71f48 to
79e115e
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 26, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 26, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 1, 2025
trivedivivek
force-pushed
the
export-D87910988
branch
from
79e115e to
29e08e6
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 1, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 1, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 1, 2025
trivedivivek
force-pushed
the
export-D87910988
branch
2 times, most recently
from
bcc50a4 to
9eb3c89
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 2, 2025
trivedivivek
force-pushed
the
export-D87910988
branch
from
9eb3c89 to
664b48c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The code change in this diff aims to improve the performance of buffer 4b matrix multiplication by reducing unnecessary computations and by spreading operations to allow better latency hiding.
Differential Revision: D87910988